RFR: 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c

[Chris Plummer]

On Thu, 5 Nov 2020 15:52:59 GMT, Claes Redestad <redestad at openjdk.org> wrote:

>> Apply patch suggested by @cl4es in the bug report.  Passes linux-x86-open,linux-x64-open,linux-s390x-open,linux-arm32-debug,linux-ppc64le-debug builds with this patch, and tier1.
>> 
>> thanks,
>> Coleen
>
> While you might want to wait for someone to suggest a better alternative, this LGTM. As you say the x86 failures on GH look related to the setup of the build image and thus unrelated to this patch.

> While it's possible that these warnings on 32-bit builds is just a matter of the compiler being wrong, it could also be that it can't determine all arguments are null-terminated. Specifying max string length in format specifiers seem a benign and cheap safeguard.

I don't think this is the case. If you assume the arguments are not null terminated, then there is no limit to how long the string could be, where-as the error messages are very specific with the (incorrectly) calculated range of potential overflow.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1067