RFR: 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c [v3]

[David Holmes]

On Thu, 5 Nov 2020 20:33:08 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Apply patch suggested by @cl4es in the bug report.  Passes linux-x86-open,linux-x64-open,linux-s390x-open,linux-arm32-debug,linux-ppc64le-debug builds with this patch, and tier1.
>> 
>> thanks,
>> Coleen
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use Thomas's fix instead.

src/jdk.jdwp.agent/share/native/libjdwp/log_messages.c line 82:

> 80:                 "%Z", localtime(&t));
> 81:     // Truncate milliseconds in buffer large enough to hold the
> 82:     // value which is always < 1000

I initially missed the %d to %s change. Can we augment the comment to say:

// value which is always < 1000 (and so a maximum of 3 digits for "%.3s")

Also I'm not clear whether this will result in extra spaces when the ms value is < 100 ?

-------------

PR: https://git.openjdk.java.net/jdk/pull/1067