RFR: 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c [v4]

[David Holmes]

On Fri, 6 Nov 2020 01:04:09 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Apply patch suggested by @cl4es in the bug report.  Passes linux-x86-open,linux-x64-open,linux-s390x-open,linux-arm32-debug,linux-ppc64le-debug builds with this patch, and tier1.
>> 
>> thanks,
>> Coleen
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Adjust millisecond format.

Marked as reviewed by dholmes (Reviewer).

src/jdk.jdwp.agent/share/native/libjdwp/log_messages.c line 83:

> 81: 
> 82:     // Truncate milliseconds in buffer large enough to hold the
> 83:     // value which is always < 1000 (and so a maximum of 3 digits for "%.3s")

With the updated code the comment is no longer correct - change %.3s to %.3d

src/jdk.jdwp.agent/share/native/libjdwp/log_messages.c line 85:

> 83:     // value which is always < 1000 (and so a maximum of 3 digits for "%.3s")
> 84:     char tmp[10 + 1];
> 85:     snprintf(tmp, sizeof(tmp), "%.3d", millisecs);

Yes this works!

-------------

PR: https://git.openjdk.java.net/jdk/pull/1067