RFR: 8066622 8066637: remove deprecated using java.io.File.toURL() in internal classes
Phil Race
prr at openjdk.java.net
Sun Nov 8 17:00:55 UTC 2020
On Sat, 7 Nov 2020 07:55:03 GMT, Sebastian Ritter <github.com+654217+bastie at openjdk.org> wrote:
> In result of Javadoc to do not use java.io.File.toURL()
> Change use java.io.File.toURL().toURI() instead.
You reference a desktop bug that discusses many, many deprecations
and skara has identified https://bugs.openjdk.java.net/browse/JDK-8066622
as the issue being fixed.
Yet you propose to fix precisely one of these.
But when this is integrated that bug will be closed out as resolved.
I think you need a new bug about JUST the changes you are making.
So I don't think you should use that bug id any where in this PR.
And I'd like to hear whether you actually *tested* splashscreen with your change ? I see no sign that you did.
-------------
Changes requested by prr (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/1108
More information about the serviceability-dev
mailing list