RFR: 8253064: monitor list simplifications and getting rid of TSM [v2]

David Holmes david.holmes at oracle.com
Mon Nov 9 23:07:21 UTC 2020


On 9/11/2020 7:05 pm, Erik Österlund wrote:
> On Sat, 7 Nov 2020 17:22:21 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:
> 
>>> src/hotspot/share/runtime/synchronizer.cpp line 1520:
>>>
>>>> 1518:     // deflated in this cycle.
>>>> 1519:     size_t deleted_count = 0;
>>>> 1520:     for (ObjectMonitor* monitor: delete_list) {
>>>
>>> I didn't realize C++ has a "foreach" loop construct! Is this in our allowed C++ usage?
>>
>> @fisk - this one is for you... :-)
> 
> Yeah this is one of the new cool features we can use. I thought it is allowed, because it is neither in the excluded nor undecided list of features in our doc/hotspot-style.md file.

But also not in the allowed list yet, so I'm checking on this - ref:

https://bugs.openjdk.java.net/browse/JDK-8254733

Cheers,
David

> -------------
> 
> PR: https://git.openjdk.java.net/jdk/pull/642
> 


More information about the serviceability-dev mailing list