RFR: 8253064: monitor list simplifications and getting rid of TSM [v6]

Daniel D.Daugherty dcubed at openjdk.java.net
Wed Nov 11 15:16:04 UTC 2020


On Wed, 11 Nov 2020 08:26:14 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

>> Daniel D. Daugherty has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   resolve more robehn and coleenp comments.
>
> src/hotspot/share/runtime/synchronizer.cpp line 1226:
> 
>> 1224:         ThreadBlockInVM tbivm(self->as_Java_thread());
>> 1225:       }
>> 1226:       os::naked_short_sleep(999);  // sleep for almost 1 second
> 
> Hi Dan, you need to be blocked while sleeping, otherwise you are blocking safepoints for "almost 1 second".
> So previous code was correct.

Good catch! Yes, I should not have written that change so late at
night. I know better. I have reverted it.

-------------

PR: https://git.openjdk.java.net/jdk/pull/642


More information about the serviceability-dev mailing list