RFR: 8255982: Extend BasicJMapTest to test with different GC Heap [v4]
Lin Zang
lzang at openjdk.java.net
Wed Nov 11 15:45:14 UTC 2020
On Wed, 11 Nov 2020 15:10:54 GMT, Igor Ignatyev <iignatyev at openjdk.org> wrote:
>> Lin Zang has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Add test id
>
> Hi @linzang ,
>
> it all looks good to me, I'd, however, keep `@build` tags as they were before, this is one of a few difference b/w jdk and hotspot test suites ( in this particular case, it actually matters as discrepancies can lead to sporadic failures). in jdk test-suite, people use a sufficient set of `@build` tag.
>
> -- Igor
Hi @iignatev,
Thanks for your explanation! recovered the @build tag.
-Lin
-------------
PR: https://git.openjdk.java.net/jdk/pull/1094
More information about the serviceability-dev
mailing list