RFR: 8250888: nsk/jvmti/scenarios/general_functions/GF08/gf08t001/TestDriver.java fails

Aleksey Shipilev shade at openjdk.java.net
Thu Nov 19 15:27:04 UTC 2020


On Thu, 19 Nov 2020 14:40:45 GMT, Guoxiong Li <github.com+13688759+lgxbslgx at openjdk.org> wrote:

> Hi all,
> 
> `TestDriver.java` used `sun.hotspot.WhiteBox.getBooleanVMFlag("Use*GC")` which could return null.
> This patch uses `sun.hotspot.gc.GC` instead of `sun.hotspot.WhiteBox` to avoid the NullPointerException.
> Thank you for taking the time to review.
> 
> Best Regards.

I believe it should be `isSelected()` rather than `isSupported()`. Try to run the test with different GCs like this to verify:
make run-test TEST=nsk/jvmti/scenarios/general_functions/GF08/gf08t001/TestDriver.java TEST_VM_OPTS=-XX:+UseShenandoahGC

-------------

Changes requested by shade (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1319


More information about the serviceability-dev mailing list