RFR: 8250888: nsk/jvmti/scenarios/general_functions/GF08/gf08t001/TestDriver.java fails [v2]

Serguei Spitsyn sspitsyn at openjdk.java.net
Thu Nov 19 18:07:09 UTC 2020


On Thu, 19 Nov 2020 15:53:15 GMT, Guoxiong Li <github.com+13688759+lgxbslgx at openjdk.org> wrote:

>> Hi all,
>> 
>> `TestDriver.java` used `sun.hotspot.WhiteBox.getBooleanVMFlag("Use*GC")` which could return null.
>> This patch uses `sun.hotspot.gc.GC` instead of `sun.hotspot.WhiteBox` to avoid the NullPointerException.
>> Thank you for taking the time to review.
>> 
>> Best Regards.
>
> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use `GC.isSelected` instead of `GC.isSupported`

Hi Guoxiong,
It looks good to me.
Thanks,
Serguei

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1319


More information about the serviceability-dev mailing list