RFR: 8245543: Cgroups: Incorrect detection logic on some systems (still reproducible) [v5]

Severin Gehwolf sgehwolf at openjdk.java.net
Thu Oct 8 13:39:00 UTC 2020


On Thu, 8 Oct 2020 13:12:02 GMT, Bob Vandette <bobv at openjdk.org> wrote:

>> Severin Gehwolf has refreshed the contents of this pull request, and previous commits have been removed. The
>> incremental views will show differences compared to the previous content of the PR. The pull request contains one new
>> commit since the last revision:
>>   8245543: Cgroups: Incorrect detection logic on some systems (still reproducible)
>
> src/java.base/linux/classes/jdk/internal/platform/CgroupSubsystemFactory.java line 185:
> 
>> 183:          } else {
>> 184:            // fallback to old, pre JDK-8245543, behaviour
>> 185:            return line.contains("cgroup");
> 
> Why are you doing this fallback rather than returning false??

The idea was to have have some basics working even though the pattern doesn't match for some reason. I guess we can
remove that as it's rather unlikely to not match.

-------------

PR: https://git.openjdk.java.net/jdk/pull/485


More information about the serviceability-dev mailing list