Integrated: 8253900: SA: wrong size computation when JVM was built without AOT

[Ziviani]

On Fri, 25 Sep 2020 13:13:44 GMT, Ziviani <github.com+670087+jrziviani at openjdk.org> wrote:

> TestInstanceKlassSize was failing because, for PowerPC, the following code (instanceKlass.cpp) always compiles to
> `return false;` bool InstanceKlass::has_stored_fingerprint() const {
> #if INCLUDE_AOT
>   return should_store_fingerprint() || is_shared();
> #else
>   return false;
> #endif
> }
> However, in `hasStoredFingerprint()@InstanceKlass.java` the condition `shouldStoreFingerprint() || isShared();` is
> always evaluated and may return true (_AFAIK isShared() returns true_). Such condition adds 8 bytes in the
> `getSize()@InstanceKlass.java` causing the failure in TestInstanceKlassSize: public long getSize() { // in number of
> bytes
>   ...
>   if (hasStoredFingerprint()) {
>     size += 8; // uint64_t
>   }
>   return alignSize(size);
> }
> Considering these tests are failing for PowerPC only (_based on ProblemList.txt_), my solution checks if
> `hasStoredFingerprint()` is running on a PowerPC platform. I decided to go this way because there is no existing flag
> informing whether AOT is included or not and creating a new one just to handle the PowerPC case seems too much.  This
> patch is an attempt to fix https://bugs.openjdk.java.net/browse/JDK-8230664

This pull request has now been integrated.

Changeset: b1448da1
Author:    Jose Ricardo Ziviani <joserz at linux.ibm.com>
Committer: Martin Doerr <mdoerr at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/b1448da1
Stats:     27 lines in 6 files changed: 24 ins; 2 del; 1 mod

8253900: SA: wrong size computation when JVM was built without AOT

Reviewed-by: cjplummer, sspitsyn

-------------

PR: https://git.openjdk.java.net/jdk/pull/358