RFR: 8253525: Implement getInstanceSize/sizeOf intrinsics [v3]

Aleksey Shipilev shade at openjdk.java.net
Tue Oct 20 17:46:18 UTC 2020


On Tue, 20 Oct 2020 17:42:00 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> test/jdk/java/lang/instrument/GetObjectSizeTest.java line 2:
>> 
>>> 1: /*
>>> 2:  * Copyright (c) 2020, Red Hat, Inc. All rights reserved.
>> 
>> You can't replace Copyright lines of one company with other.
>
> Well, I am replacing the entire file. There is a recent precedent of the similar change
> [here](https://github.com/openjdk/jdk/commit/6d13c766#diff-0daf75421f8fdb55a5640742ef6f12730fe1b370cc864311c188ad99996b51fe).
> Either that should be reversed, or this one accepted.

...or I can put new test into a separate file. But the existing test is quite inferior compared to the new one, so it
does not seem to make a lot of sense to keep it.

-------------

PR: https://git.openjdk.java.net/jdk/pull/650


More information about the serviceability-dev mailing list