RFR: 8254723: add diagnostic command to write Linux perf map file [v2]

Nick Gasson ngasson at openjdk.java.net
Wed Oct 21 09:13:11 UTC 2020


On Tue, 20 Oct 2020 11:43:17 GMT, Vladimir Sitnikov <github.com+213894+vlsi at openjdk.org> wrote:

>> Nick Gasson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update for review comments
>
> test/hotspot/jtreg/serviceability/dcmd/compiler/PerfMapTest.java line 68:
> 
>> 66:         Matcher m = outputPattern.matcher(line);
>> 67: 
>> 68:         Assert.assertTrue(m.matches(), "Did not print map file name");
> 
> Suggestion:
> 
>         Assert.assertTrue(m.matches(), "Did not print map file name, line = " + line);

Done, thanks.

-------------

PR: https://git.openjdk.java.net/jdk/pull/760


More information about the serviceability-dev mailing list