RFR: 8254723: add diagnostic command to write Linux perf map file [v2]

Serguei Spitsyn sspitsyn at openjdk.java.net
Wed Oct 21 21:04:16 UTC 2020


On Wed, 21 Oct 2020 21:00:01 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> Any reason not to have this dcmd supported on all platforms even though the output is really targeted for use with the perf tool on linux? Would a user ever have any other use for the output other than with the perf tool on linux?
>
> +#ifdef LINUX
> +  DCmdFactory::register_DCmdFactory(new DCmdFactoryImpl<PerfMapDCmd>(full_export, true, false));
> +#endif // LINUX
> 
> If this PR is for Linux only then I wonder if all changes have to be ifdef'ed the same or similar way.

Sorry, I've overlooked that @YaSuenag posted similar comment.

-------------

PR: https://git.openjdk.java.net/jdk/pull/760


More information about the serviceability-dev mailing list