RFR: 8254861: reformat code in vmTestbase/nsk/jdb [v2]
Serguei Spitsyn
sspitsyn at openjdk.java.net
Thu Oct 22 08:06:18 UTC 2020
On Mon, 19 Oct 2020 20:57:03 GMT, Igor Ignatyev <iignatyev at openjdk.org> wrote:
>> test/hotspot/jtreg/vmTestbase/nsk/jdb/hidden_class/hc001/hc001.java line 323:
>>
>>> 321: "xx.yyy/0x111/0x222",
>>> 322: "xx./0x111.0x222",
>>> 323: "xx.yyy.zzz/"
>>
>> Why are these indented 8 instead of 4?
>
> due to the same reasons in the case w/ `fields001`, these lines have 3 unit indentation, 1st for `hc001` class, 2nd for `testInvalidCommands` method, 3rd for `invClassNames` array initialization, so they have 3x4 = 12 spaces.
File test/hotspot/jtreg/vmTestbase/nsk/jdb/kill/kill001/kill001.java has this change:
for (int i = 0; i < threads.length; i++) {
reply = jdb.receiveReplyForWithMessageWait(JdbCommand.kill + threads[i] + " " +
- DEBUGGEE_EXCEPTIONS + "[" + i + "]",
- "killed");
+ DEBUGGEE_EXCEPTIONS + "[" + i + "]",
+ "killed");
}
I think, the second line "killed"); has to be aligned with the previous one.
-------------
PR: https://git.openjdk.java.net/jdk/pull/689
More information about the serviceability-dev
mailing list