RFR: 8223312: Utilize handshakes instead of is_thread_fully_suspended [v3]

Robbin Ehn rehn at openjdk.java.net
Thu Oct 22 10:31:16 UTC 2020


On Thu, 22 Oct 2020 10:04:01 GMT, Erik Österlund <eosterlund at openjdk.org> wrote:

>> @robehn you haven't messed up. Hope I havn't either. I've tested
>> 
>> ==============================
>> Test summary
>> ==============================
>>    TEST                                              TOTAL  PASS  FAIL ERROR   
>>    jtreg:test/hotspot/jtreg:hotspot_serviceability     197   197     0     0   
>>    jtreg:test/jdk:jdk_svc                             1176  1176     0     0   
>>    jtreg:test/jdk:jdk_jdi                              174   174     0     0   
>>    jtreg:test/hotspot/jtreg:vmTestbase_nsk_jdi        1141  1141     0     0   
>>    jtreg:test/hotspot/jtreg:vmTestbase_nsk_jvmti       648   648     0     0   
>>    jtreg:test/hotspot/jtreg:vmTestbase_nsk_jdwp        113   113     0     0   
>> ==============================
>> TEST SUCCESS
>> jdk_jdi now includes jdk/com/sun/jdi/EATests.java which tests PopFrame/ForceEarlyReturn with object reallocation with and without reallocation failures.
>
> Ah. I see now the loop uses <= instead of <. So my reasoning was right but off by 1. Passing in 0 really means deopt 1 frame. Which means everything is fine and working the way I expect it to.

Great

-------------

PR: https://git.openjdk.java.net/jdk/pull/729


More information about the serviceability-dev mailing list