Integrated: 8223312: Utilize handshakes instead of is_thread_fully_suspended
Robbin Ehn
rehn at openjdk.java.net
Thu Oct 22 15:23:27 UTC 2020
On Mon, 19 Oct 2020 09:59:34 GMT, Robbin Ehn <rehn at openjdk.org> wrote:
> The main point of this change-set is to make it easier to implement S/R on top of handshakes.
> Which is a prerequisite for removing _suspend_flag (which duplicates the handshake functionality).
> But we also remove some complicated S/R methods.
>
> We basically just put in everything in the handshake closure, so the diff just looks much worse than what it is.
>
> TraceSuspendDebugBits have an ifdef, but in both cases it now just returns.
> But I was unsure if I should remove now or when is_ext_suspend_completed() is removed.
>
> Passes multiple t1-5 runs, locally it passes many jck:vm/nsk_jvmti/nsk_jdi/jdk-jdi runs.
This pull request has now been integrated.
Changeset: 4634dbef
Author: Robbin Ehn <rehn at openjdk.org>
URL: https://git.openjdk.java.net/jdk/commit/4634dbef
Stats: 611 lines in 6 files changed: 174 ins; 376 del; 61 mod
8223312: Utilize handshakes instead of is_thread_fully_suspended
Reviewed-by: dholmes, rrich, dcubed, eosterlund
-------------
PR: https://git.openjdk.java.net/jdk/pull/729
More information about the serviceability-dev
mailing list