RFR: 8252117: com/sun/jdi/BadHandshakeTest.java failed with "ConnectException: Connection refused: connect"

[Chris Plummer]

On Thu, 22 Oct 2020 00:00:17 GMT, Alex Menkov <amenkov at openjdk.org> wrote:

> Please review the fix for BadHandshakeTest.
> Summary:
> The test verifies that bad (testcase1) or incomplete (testcase2) handshake does not cause debuggee termination.
> To check this it tries to attach to the debuggee again (connect in testcase2 is also verification for testcase1)
> 
> The fix adds reply logic to the last attach (similar to retry logic in testcase2)

Other than the one comment I noted, the changes look good. Was the failure rate high enough that you've been able to prove your fix works?

test/jdk/com/sun/jdi/BadHandshakeTest.java line 159:

> 157:             }
> 158: 
> 159:             // get the debuggee some time to exit before forcibly terminate it

"give", not "get". Also, "terminating", not "terminate".

-------------

Marked as reviewed by cjplummer (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/789