RFR: 8254723: add diagnostic command to write Linux perf map file [v2]

Nick Gasson ngasson at openjdk.java.net
Mon Oct 26 06:13:40 UTC 2020


On Wed, 21 Oct 2020 18:03:11 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Nick Gasson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update for review comments
>
> src/hotspot/share/code/codeCache.cpp line 1582:
> 
>> 1580:       cb->is_compiled() ? cb->as_compiled_method()->method()->external_name()
>> 1581:                         : cb->name();
>> 1582:     fs.print_cr(INTPTR_FORMAT " " INTPTR_FORMAT " %s",
> 
> Indentation isn't right.

Do you mean how the arguments are lined up on the continuation line below?

-------------

PR: https://git.openjdk.java.net/jdk/pull/760


More information about the serviceability-dev mailing list