RFR: 8252117: com/sun/jdi/BadHandshakeTest.java failed with "ConnectException: Connection refused: connect" [v2]

Serguei Spitsyn sspitsyn at openjdk.java.net
Mon Oct 26 18:30:21 UTC 2020


On Fri, 23 Oct 2020 22:44:50 GMT, Alex Menkov <amenkov at openjdk.org> wrote:

>> Please review the fix for BadHandshakeTest.
>> Summary:
>> The test verifies that bad (testcase1) or incomplete (testcase2) handshake does not cause debuggee termination.
>> To check this it tries to attach to the debuggee again (connect in testcase2 is also verification for testcase1)
>> 
>> The fix adds reply logic to the last attach (similar to retry logic in testcase2)
>
> Alex Menkov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix the comment

Hi Alex,
It looks good.
Thanks,
Serguei

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/789


More information about the serviceability-dev mailing list