RFR: 8253939: [TESTBUG] Increase coverage of the cgroups detection code [v4]
Bob Vandette
bobv at openjdk.java.net
Wed Oct 28 15:45:52 UTC 2020
On Wed, 28 Oct 2020 13:49:53 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:
>> Test only change. With [JDK-8253435](https://bugs.openjdk.java.net/browse/JDK-8253435) a test has been added on the hotspot side, but nothing for the Java Metrics code. Same for [JDK-8252359](https://bugs.openjdk.java.net/browse/JDK-8252359).
>>
>> When JDK-8217766 got fixed cgroup factories with the detection logic didn't exist so were harder to test. This patch adds tests for them too.
>>
>> Thoughts?
>
> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision:
>
> 8253939: [TESTBUG] Increase coverage of the cgroups detection code
Looks good.
-------------
Marked as reviewed by bobv (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/609
More information about the serviceability-dev
mailing list