RFR: 8255455: Pre-generate ThreadHeapSampler::_log_table [v6]
Claes Redestad
redestad at openjdk.java.net
Fri Oct 30 15:27:58 UTC 2020
On Thu, 29 Oct 2020 20:04:11 GMT, Ioi Lam <iklam at openjdk.org> wrote:
>> Claes Redestad has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Add explicit include of logging
>> - Add const, fix copyright
>
> Marked as reviewed by iklam (Reviewer).
@iklam: I added a runtime verification pass that the values in the log_table are reasonably accurate. This adds around 100k instructions on startup on a debug build, which is in the noise there (currently hello world takes 470M on fastdebug builds). The checking is disabled in a code gen run to not put up tripwires when resizing the table.
-------------
PR: https://git.openjdk.java.net/jdk/pull/880
More information about the serviceability-dev
mailing list