RFR: 8255455: Pre-generate ThreadHeapSampler::_log_table [v7]

Claes Redestad redestad at openjdk.java.net
Fri Oct 30 18:18:58 UTC 2020


On Fri, 30 Oct 2020 17:39:05 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Claes Redestad has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since the last revision:
>> 
>>  - Merge branch 'master' into threadHeapSampler_constexpr
>>  - Check log_table on startup in debug builds
>>  - Add explicit include of logging
>>  - Add const, fix copyright
>>  - Desugar constexpr into code generator and output
>>  - Merge branch 'master' into threadHeapSampler_constexpr
>>  - Declare and define log_table as a static constexpr inside threadHeapSampler.cpp
>>  - Merge branch 'master' into threadHeapSampler_constexpr
>>  - Merge branch 'master' into threadHeapSampler_constexpr
>>  - Remove _log_table_initialized assert
>>  - ... and 1 more: https://git.openjdk.java.net/jdk/compare/7a199d94...0eebe57c
>
> LGTM

@iklam: thanks!

-------------

PR: https://git.openjdk.java.net/jdk/pull/880


More information about the serviceability-dev mailing list