RFR: 8252657: JVMTI agent is not unloaded when Agent_OnAttach is failed

[serguei.spitsyn at oracle.com]

Hi Yasumasa,

It looks good to me.

Thanks,
Serguei


On 9/1/20 15:28, Yasumasa Suenaga wrote:
> On 2020/09/02 1:00, Daniel D. Daugherty wrote:
>> On 9/1/20 9:42 AM, Yasumasa Suenaga wrote:
>>> Hi all,
>>>
>>> Please review this change:
>>>
>>>   JBS: https://bugs.openjdk.java.net/browse/JDK-8252657
>>>   webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8252657/webrev.00/
>>>
>>> I tried to attach JVMTI agent which returns JNI_ERR in 
>>> Agent_OnUnload via JVMTI.agent_load dcmd.
>>
>> The above says Agent_OnUnload(), but the synopsis for the bug
>> says "Agent_OnAttach" so I'm confused about what you're trying
>> to say here.
>
> Sorry, Agent_OnAttach is correct.
>
> Yasumasa
>
>> Dan
>>
>>
>>
>>> I expected the library would be unloaded, but I saw it in VM.dynlibs 
>>> dcmd even though it was failed to load.
>>>
>>> Please see JBS how to reproduce.
>>>
>>>
>>> Thanks,
>>>
>>> Yasumasa
>>