RFR: 8252406: Introduce Thread::as_Java_thread() convenience function [v5]

David Holmes david.holmes at oracle.com
Tue Sep 8 22:05:51 UTC 2020


Thanks for the review Coleen!

David

On 9/09/2020 5:10 am, Coleen Phillimore wrote:
> On Tue, 8 Sep 2020 19:07:01 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
> 
>>> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
>>>
>>>    This is a simpler approach to use the static_cast. Changes:
>>>    - Change C-style cast to static_cast and move function definitions so this works.
>>>    - Use overloading for const and non-const versions of as_Java_thread().
>>>    - Update copyright years.
>>>    
>>>    Re-testing builds in tiers 1-5.
>>>    
>>>    Thanks.
>>
>> Marked as reviewed by coleenp (Reviewer).
> 
> I'll look at v5 diffs but if I don't, this is still reviewed.  Nice cleanup.
> 
> -------------
> 
> PR: https://git.openjdk.java.net/jdk/pull/37
> 


More information about the serviceability-dev mailing list