RFR: 8252537: Updated @exception with @throws
Vipin Sharma
vsharma at openjdk.java.net
Tue Sep 15 19:16:22 UTC 2020
On Tue, 15 Sep 2020 18:14:58 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:
>> Updated @exception with @throws for core-libs, it fixes all open sub-tasks of JDK-8252536.
>>
>> Open Subtasks part of this fix are:
>> 1. JDK-8252537
>> 2. JDK-8252539
>> 3. JDK-8252540
>> 4. JDK-8252541
>>
>> Previous conversation on this:
>> https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-September/068540.html
>
> I've only looked at the management files. They look good in general.
>
> src/java.management/share/classes/java/lang/management/ClassLoadingMXBean.java
>
> 108 * @throws java.lang.SecurityException if a security manager
> 109 * exists and the caller does not have
> 110 * ManagementPermission("control").
>
>
> src/java.management/share/classes/java/lang/management/MemoryMXBean.java
>
> 286 * @throws java.lang.SecurityException if a security manager
> 287 * exists and the caller does not have
> 288 * ManagementPermission("control").
>
> Could you, please, fix the indentation?
@RogerRiggs I understand your point and will update PR with correct indentation.
But I think adding 3 spaces after throws may not be right for all cases.
For example when
1. Another tag in same method is using only 1 space.
2. In some cases (e.g. free method of Blob.java) we had a mix of throws and exception in the same method both with one
space after. Here after adding 3 spaces throws tags will have the different number of spaces and indentation will not
be same as before.
I will update PR to make sure the indentation looks same as before and there is no change in javadoc.
Please tell me in case my understnding is not correct here.
-------------
PR: https://git.openjdk.java.net/jdk/pull/95
More information about the serviceability-dev
mailing list