RFR: 8241390: 'Deadlock' with VM_RedefineClasses::lock_classes()

Serguei Spitsyn sspitsyn at openjdk.java.net
Wed Sep 16 06:59:02 UTC 2020


On Tue, 15 Sep 2020 20:02:38 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> The change fixes a 'deadlock' situation in VM_RedefineClasses::lock_classes() when the current thread is in the middle
>> of redefining the same class. The change is based on the fix [1] suggested in the Jira issue [2] comment.
>> [1] http://cr.openjdk.java.net/~jiangli/8241390/webrev.00/
>> [2] https://bugs.openjdk.java.net/browse/JDK-8241390
>> 
>> Testing: :jdk_instrument, tier1-tier3, and tier5 tests pass.
>
> Changes requested by coleenp (Reviewer).

The identifier 'cls' does not reflect the nature of the object and needs to be replaces with something like:
  classes, redef_classes or classes_list
This impacts the files: jvmtiThreadState.hpp and jvmtiRedefineClasses.cpp.

-------------

PR: https://git.openjdk.java.net/jdk/pull/190


More information about the serviceability-dev mailing list