RFR: 8247281: migrate ObjectMonitor::_object to OopStorage [v5]

[Daniel D.Daugherty]

On Wed, 16 Sep 2020 00:20:16 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> I've taken a first pass at creating a CSR:
>> JDK-8253121 migrate ObjectMonitor::_object to OopStorage
>> https://bugs.openjdk.java.net/browse/JDK-8253121
>
> Just a minor comment.
> The line 1754 can be deleted as the JVMTI_HEAP_REFERENCE_MONITOR reference type will be never encountered:
> 
> 1750 static jvmtiHeapRootKind toJvmtiHeapRootKind(jvmtiHeapReferenceKind kind) {
> 1751   switch (kind) {
> 1752     case JVMTI_HEAP_REFERENCE_JNI_GLOBAL:   return JVMTI_HEAP_ROOT_JNI_GLOBAL;
> 1753     case JVMTI_HEAP_REFERENCE_SYSTEM_CLASS: return JVMTI_HEAP_ROOT_SYSTEM_CLASS;
> 1754     case JVMTI_HEAP_REFERENCE_MONITOR:      return JVMTI_HEAP_ROOT_MONITOR;
> 1755     case JVMTI_HEAP_REFERENCE_STACK_LOCAL:  return JVMTI_HEAP_ROOT_STACK_LOCAL;
> 1756     case JVMTI_HEAP_REFERENCE_JNI_LOCAL:    return JVMTI_HEAP_ROOT_JNI_LOCAL;
> 1757     case JVMTI_HEAP_REFERENCE_THREAD:       return JVMTI_HEAP_ROOT_THREAD;
> 1758     case JVMTI_HEAP_REFERENCE_OTHER:        return JVMTI_HEAP_ROOT_OTHER;
> 1759     default: ShouldNotReachHere();          return JVMTI_HEAP_ROOT_OTHER;
> 1760   }
> 1761 }
> 
> Other than that the update in this file looks okay to me.

I cleaned that up. The only references to JVMTI_HEAP_REFERENCE_MONITOR and
JVMTI_HEAP_ROOT_MONITOR that remain are in the spec:

$ egrep -r 'JVMTI_HEAP_REFERENCE_MONITOR|JVMTI_HEAP_ROOT_MONITOR' src/hotspot
src/hotspot/share/prims/jvmti.xml:          <constant id="JVMTI_HEAP_REFERENCE_MONITOR" num="23">
src/hotspot/share/prims/jvmti.xml:          <constant id="JVMTI_HEAP_ROOT_MONITOR" num="3">
src/hotspot/share/prims/jvmti.xml:              <code>JVMTI_HEAP_ROOT_MONITOR</code>,

-------------

PR: https://git.openjdk.java.net/jdk/pull/135