RFR: 8252997: Null-proofing for linker_md.c

Serguei Spitsyn sspitsyn at openjdk.java.net
Fri Sep 18 20:59:54 UTC 2020


On Fri, 18 Sep 2020 20:23:15 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> In the platform-specific implementations of linker_md.c, we see the dll_build_name methods begin with a call to
>> jvmtiAllocate.
>> We then appear to rush ahead and try to use that variable without checking for a null.
>> 
>> I propose moving the null check to the point *before* we try to use that variable, to avoid any possible SEGV.
>> 
>> Bug link: https://bugs.openjdk.java.net/browse/JDK-8252997
>
> Both files need copyright updates before pushing. Otherwise the changes look good.

The fix looks okay to me.
But I have a dejavu that I've already reviewed it.

-------------

PR: https://git.openjdk.java.net/jdk/pull/246


More information about the serviceability-dev mailing list