RFR: 8252997: Null-proofing for linker_md.c

Chris Plummer cjplummer at openjdk.java.net
Fri Sep 18 22:28:05 UTC 2020


On Fri, 18 Sep 2020 11:09:19 GMT, Adam Farley <afarley at openjdk.org> wrote:

> In the platform-specific implementations of linker_md.c, we see the dll_build_name methods begin with a call to
> jvmtiAllocate.
> We then appear to rush ahead and try to use that variable without checking for a null.
> 
> I propose moving the null check to the point *before* we try to use that variable, to avoid any possible SEGV.
> 
> Bug link: https://bugs.openjdk.java.net/browse/JDK-8252997

Both files need copyright updates before pushing. Otherwise the changes look good.

-------------

Changes requested by cjplummer (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/246


More information about the serviceability-dev mailing list