Integrated: 8234808: jdb quoted option parsing broken
Alex Menkov
amenkov at openjdk.java.net
Tue Sep 22 00:07:50 UTC 2020
On Wed, 16 Sep 2020 19:47:02 GMT, Alex Menkov <amenkov at openjdk.org> wrote:
> Migrating this review from the mailing list into a pull request.
>
> Some background:
> when jdb launches debuggee process it passes java options from "options" value for CommandLineLaunch connector and
> forward options specified before command.
> The fix solves several discovered issues:
> - proper handling of java options with spaces
> - if both way are used to specify java options, forwarded options override options from "options" value
>
> VMConnection class implements tricky logic for "options" field parsing for JFR needs (handling of single and double
> quotes). I decided to keep it as is to avoid massive test failures with JFR (there is no test coverage for this
> functionality and I'm not sure I understand all requirements).
This pull request has now been integrated.
Changeset: d1f9b8a8
Author: Alex Menkov <amenkov at openjdk.org>
URL: https://git.openjdk.java.net/jdk/commit/d1f9b8a8
Stats: 205 lines in 4 files changed: 4 ins; 190 del; 11 mod
8234808: jdb quoted option parsing broken
Reviewed-by: cjplummer, sspitsyn
-------------
PR: https://git.openjdk.java.net/jdk/pull/211
More information about the serviceability-dev
mailing list