RFR: 8227745: Enable Escape Analysis for Better Performance in the Presence of JVMTI Agents
Serguei Spitsyn
sspitsyn at openjdk.java.net
Tue Sep 22 00:41:05 UTC 2020
On Thu, 17 Sep 2020 07:45:52 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:
>> Marked as reviewed by goetz (Reviewer).
>
> Reviewed in the good old hg times :)
> See also http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2020-August/041453.html
src/hotspot/share/opto/macro.cpp:
@@ -1091,11 +1091,11 @@
bool PhaseMacroExpand::eliminate_allocate_node(AllocateNode *alloc) {
// Don't do scalar replacement if the frame can be popped by JVMTI:
// if reallocation fails during deoptimization we'll pop all
// interpreter frames for this compiled frame and that won't play
// nice with JVMTI popframe.
- if (!EliminateAllocations || JvmtiExport::can_pop_frame() || !alloc->_is_non_escaping) {
+ if (!EliminateAllocations || !alloc->_is_non_escaping) {
return false;
}
I wonder if the comment is still correct after you removed the check for JvmtiExport::can_pop_frame().
-------------
PR: https://git.openjdk.java.net/jdk/pull/119
More information about the serviceability-dev
mailing list