RFR: 8238761: Asynchronous handshakes [v5]

Robbin Ehn rehn at openjdk.java.net
Tue Sep 22 14:09:50 UTC 2020


On Tue, 22 Sep 2020 12:14:19 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Robbin Ehn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update after Coleen
>
> src/hotspot/share/prims/whitebox.cpp line 2050:
> 
>> 2048:     JavaThread* target = java_lang_Thread::thread(thread_oop);
>> 2049:     TraceSelfClosure* tsc = new TraceSelfClosure(target);
>> 2050:     Handshake::execute(tsc, target);
> 
> I know it's a whitebox test, but should this delete TraceSelfClosure sometime?

Please have a look here, we delete it if we fail to install it:
https://github.com/openjdk/jdk/blob/cd784a751a3153939b9284898f370160124ca610/src/hotspot/share/runtime/handshake.cpp#L352
Here we delete it after we processed it:
https://github.com/openjdk/jdk/blob/cd784a751a3153939b9284898f370160124ca610/src/hotspot/share/runtime/handshake.cpp#L419

Since this as async op, the requester can't safely delete it.

-------------

PR: https://git.openjdk.java.net/jdk/pull/151


More information about the serviceability-dev mailing list