RFR: 8251999: remove usage of PropertyResolvingWrapper in vmTestbase/nsk/aod

Serguei Spitsyn sspitsyn at openjdk.java.net
Wed Sep 23 06:54:51 UTC 2020


On Tue, 22 Sep 2020 21:13:53 GMT, Igor Ignatyev <iignatyev at openjdk.org> wrote:

> the patch
> - removes `PropertyResolvingWrapper` from `vmTestbase/nsk/aod` tests
> - updates `AODRunnerArgParser` to remove surrounding `"` symbols from `javaOpts` option values
> - updates vmTestbase/nsk/aod test descriptions to have `"` in `javaOpts` values (as opposed of around `-javaOpts=$value`
>   as it's now)
> - mechanically reformats/cleans up the tests (whitespaces, imports, etc)
> 
> testing:
> * [x] vmTestbase/nsk/aod on  {macosx,windows,linux}-x64
> * [x] vmTestbase/nsk/aod on macosx-x64 w/ `VM_OPTIONS`, `JAVA_OPTIONS` being empty and having value

Igor, the fix looks good to me.
Thank you for all these style and import changes!

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/311


More information about the serviceability-dev mailing list