RFR: 8253180: ZGC: Implementation of JEP 376: ZGC: Concurrent Thread-Stack Processing [v3]

Erik Österlund eosterlund at openjdk.java.net
Wed Sep 23 13:57:11 UTC 2020


On Wed, 23 Sep 2020 12:59:40 GMT, Erik Österlund <eosterlund at openjdk.org> wrote:

>> src/hotspot/share/runtime/stackWatermarkSet.cpp line 112:
>> 
>>> 110:     return;
>>> 111:   }
>>> 112:   verify_poll_context();
>> 
>> There's a verfy_poll_context here, but no update_poll_values call. I guess this is because we could be iterating over a
>> thread that is not Thread::current()? But in that case, should we really be "verifying the poll context" of the current
>> thread?
>
> Correct - I'm not updating the poll values, because it's not necessarily the current thread we are processing. But the
> verify_poll_context() code does correctly always refer to the current frame. It verifies we are in the right context to
> perform this kind of processing, yet the processing could be for a different thread.

Updating the name to verify_processing_context to better reflect what this does.

-------------

PR: https://git.openjdk.java.net/jdk/pull/296


More information about the serviceability-dev mailing list