RFR: 8253372: [TESTBUG] update tests which require jvmti - hotspot

Alex Menkov amenkov at openjdk.java.net
Wed Sep 23 21:11:55 UTC 2020


On Tue, 22 Sep 2020 23:36:04 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> This is subtask which covers test in hotspot/jtreg except test/hotspot/jtreg/vmTestbase/nsk/jvmti (there is a separate
>> issue for it: JDK-8253371)
>> In most tests just "@requires vm.jvmti" is added,
>> in several test '@requires vm.flavor != "minimal"' is removed (when this requirement is only to ensure test VM has
>> JVMTI included)
>
> The CDS test changes look good to me. Thanks for doing this.

> 
> 
> How did you determine the list of tests that need jvmti?

I tried to run all hotspot tests, but it failed due timeout. Main reason is absence of management (management module
presents in minimal, but contains only stubs). There is a separate issue for management requirement: JDK-8252474 So I
got the list by combining 2 ways:
- search for known functionalities which require jvmti (java.instrument, javaagent/agentlib)
- run subsets of the tests and looked at the failure reasons

So I can miss some tests which need to be updated, but it will be much simpler to identify them after JDK-8252474 is
fixed

-------------

PR: https://git.openjdk.java.net/jdk/pull/314


More information about the serviceability-dev mailing list