RFR: 8238761: Asynchronous handshakes [v5]

[Serguei Spitsyn]

On Wed, 23 Sep 2020 04:10:36 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Robbin Ehn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update after Coleen
>
> No significant comments. All my concerns relate to naming and terminology, where I think there is scope for quite a bit
> of tidying up. Thanks.

Hi Robbin,
I've looked more at the Serviceability files.
The fix looks good in general. Nice refactoring and simplification with the JvmtiHandshakeClosure.
It is a little unexpected that the do_thread can be executed by non-JavaThread's.
Not sure, what kinds of inconvenience it can cause.
Also, adding the _completed field is somewhat inconsistent.
I'd expect it to be present or not present for almost all JVMTI handshake closures.
I hope, you can comment on why it was added in these particular cases.

-------------

PR: https://git.openjdk.java.net/jdk/pull/151