RFR: 8252003: remove usage of PropertyResolvingWrapper in vmTestbase/nsk/jvmti
Igor Ignatyev
iignatyev at openjdk.java.net
Sat Sep 26 04:39:22 UTC 2020
Hi all,
could you please review the patch which removes `PropertyResolvingWrapper` from `vmTestbase/nsk/jvmti` tests? as
`jtreg` doesn't support spaces in the arguments and doesn't handle `"` in any special ways, the patch also:
- `s/"-javaOpts=/-javaOpts="/`
- makes `nsk.jvmti.scenarios.general_functions.GF08` to use 2nd arg as `verboseType` and 3rd and the rest args
concatenated as `phrase` and updates the tests accordingly
- removes spaces and surrounding `"` from `nsk.jvmti.test.property*`
- removes `"` surrounding `-agentlib:`, replaces spaces in `-agentlib` with `,` and updates `ArgumentHandler` to treat
`,` (as well as ` ` and `~`) as options delimiters, so it's consistent w/ `jvmti_tools.cpp`
testing: ⏳ `vmTestbase/nsk/jvmti` on {linux,windows,macos}-x64
-------------
Commit messages:
- removed redundant ExecDriver
- copyright year update
- remove spaces and surrounding " from nsk.jvmti.test.property*
- make 2nd arg being `verboseType` and 3rd+ concatenated -- `phrase`
- update ArgumentHandler to use the same delimeters as in jvmti_tools.cpp
- remove " around -agentlib
- s/"-javaOpts=/-javaOpts="/
- 8252003: remove usage of PropertyResolvingWrapper in vmTestbase/nsk/jvmti
Changes: https://git.openjdk.java.net/jdk/pull/370/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=370&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8252003
Stats: 601 lines in 166 files changed: 14 ins; 149 del; 438 mod
Patch: https://git.openjdk.java.net/jdk/pull/370.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/370/head:pull/370
PR: https://git.openjdk.java.net/jdk/pull/370
More information about the serviceability-dev
mailing list