RFR: 8252001: remove usage of PropertyResolvingWrapper in vmTestbase/nsk/jdi

Igor Ignatyev iignatyev at openjdk.java.net
Mon Sep 28 15:52:53 UTC 2020


Hi all,

could you please review the patch which removes `PropertyResolvingWrapper` from `vmTestbase/nsk/jdi`? other than the
removal of `PropertyResolvingWrapper` from jtreg actions, the patch also
 - `s/"-debugee.vmkeys=/-debugee.vmkeys="/`
 - removed `ExecDriver` there it's not needed anymore
 - as jtreg doesn't support static nested classes as main test classes, all `EventTestTemplates`s inner classes were moved
   up and the tests were updated accordingly
 - appended ${java.class.path} to `-cp` in the tests which specify classpath, otherwise, these tests fail due to CNFE of
   jtreg tests
 - escaped `"` on windows in `nsk.share.jdi.Binder`
 - replaced default quote (`"`) w/ `\0` in `n.s.j.Binder` so there will be no clashes w/ `"` from actions

testing: ✅ `vmTestbase/nsk/jdi` tests on `{linux,windows,macos}-x64`

-------------

Commit messages:
 - fixed whitespaces
 - append ${java.class.path} to -cp
 - moved up EventTestTemplates's inner classes
 - use \0 as quote and escape " on windows (as in nsk.share.jpda.DebugeeBinder)
 - removed TEST.properties
 - s/"-debugee.vmkeys=/-debugee.vmkeys="/
 - removed redundant ExecDriver
 - 8252001: remove usage of PropertyResolvingWrapper in vmTestbase/nsk/jdi

Changes: https://git.openjdk.java.net/jdk/pull/379/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=379&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8252001
  Stats: 3401 lines in 1157 files changed: 588 ins; 397 del; 2416 mod
  Patch: https://git.openjdk.java.net/jdk/pull/379.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/379/head:pull/379

PR: https://git.openjdk.java.net/jdk/pull/379


More information about the serviceability-dev mailing list