RFR: 8238761: Asynchronous handshakes [v9]

Robbin Ehn rehn at openjdk.java.net
Tue Sep 29 08:57:41 UTC 2020


On Tue, 29 Sep 2020 06:25:40 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Robbin Ehn has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev
>> excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since
>> the last revision:
>>  - More fixes from David
>>  - Merge branch 'master' into 8238761-asynchrounous-handshakes
>>  - Add constructor and comment. Previous renames caused confusing, improved names once more and moved non-public to private
>>  - Fixed trailing whitespace
>>  - Update after David
>>  - Update after Coleen
>>  - Update after Dan and David
>>  - Merge branch 'master' into 8238761-asynchrounous-handshakes
>>  - Removed double check, fix comment, removed not needed function, updated logs
>>  - Fixed double checks
>>    Added NSV
>>    ProcessResult to enum
>>    Fixed logging
>>    Moved _active_handshaker to private
>>  - ... and 1 more: https://git.openjdk.java.net/jdk/compare/5335e46d...3a95750e
>
> Hi Robbin,
> Thanks for the updates and the slack chat to clarify my misunderstanding of the queuing mechanism.
> 
> I agree that the logging statements are somewhat confusing as they were written when the processing logic was much
> simpler, but I understand now the count of emitted executed operations.
> This all looks good to me now.
> Thanks,
> David

Thanks all!

-------------

PR: https://git.openjdk.java.net/jdk/pull/151


More information about the serviceability-dev mailing list