RFR: 8253815: Remove unused HeapRegionManager::_num_committed from SA

Stefan Johansson sjohanss at openjdk.java.net
Tue Sep 29 21:36:53 UTC 2020


On Tue, 29 Sep 2020 21:32:07 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> The field will remain for now, but the plan is to refactor it into a new class. The new class is not needed by the SA
>> and I would really like to avoid having to add unused and untested code to the SA. To simplify this coming change I
>> want to remove this from the SA straight away.   Even without this coming change I would vote for removing this type of
>> unused code from the SA. I don't think being able to dump the value is worth enough compared to the maintenance cost of
>> keeping it in.
>
> Ok. If the field is going away eventually then you can remove it now.

Awesome, thanks for reviewing.

-------------

PR: https://git.openjdk.java.net/jdk/pull/408


More information about the serviceability-dev mailing list