RFR: 8252000: remove usage of PropertyResolvingWrapper in vmTestbase/nsk/jdb [v3]

Tue Sep 29 23:52:01 UTC 2020

On Tue, 29 Sep 2020 21:52:18 GMT, Igor Ignatyev <iignatyev at openjdk.org> wrote:

>> the patch
>> - removes `PropertyResolvingWrapper` from `vmTestbase/nsk/jdb` tests
>> - updates `JdbArgumentHandler` to remove `"` from `jdb.option` option
>> - reformats code
>> 
>> testing:
>> ✅ `vmTestbase/nsk/jdb` on {macosx,linux,windows}-x64
>
> Igor Ignatyev has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - update copyright years
>  - Revert "realign table in locals002"
>    Revert "updated copyright year"
>    Revert "move var declarations closer to the 1st use"
>    Revert "reformat code"
>    
>    This reverts commits:
>     - a092273924c7066bf64f85d8d433050f8ec64c93
>     - ba7ce635e04c583588c613f03e00a7c78d604520
>     - e79328980f98204a12fe04868c4f72bedd32879b
>     - 2cd3ef188433225139e90fef3bf71cb9f3170451

The changes look good, but can you clarify (preferably in the CR) why the getJdbOptions() changes are needed when
removing the use of PropertyResolvingWrapper?

-------------

Marked as reviewed by cjplummer (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/350