RFR: 8252003: remove usage of PropertyResolvingWrapper in vmTestbase/nsk/jvmti
Igor Ignatyev
iignatyev at openjdk.java.net
Wed Sep 30 17:58:00 UTC 2020
On Wed, 30 Sep 2020 17:53:14 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:
>> the reason I had to this change is that jtreg doesn't handle `"` in any special way, so `gf08t003
>> nsk.jvmti.scenarios.general_functions.GF08.gf08t003 "Registering JNI native method" jni` is passed to `gf08t` as
>> [`gf08t003`, `nsk.jvmti.scenarios.general_functions.GF08.gf08t003`, `"Registering`, `JNI`, `native`, `method"`, `jni`].
>> the way I fixed that was by changing the order of `phrase`, `verboseType`, so `verboseType` is now 2nd arg, and
>> `phrase` 3rd and the rest of args joined. the alternative way would be to teach `gf08t` about `"` and make it join
>> arguments until it gets an even number of `"` and remove them, this, from my PoV, would be a bit more confusing. if
>> you, however, are of strong opinion here, I can go w/ that alternative (or any other if you have more suggestions)
>
> So what code used to handle passing quoted arguments? Is this something that PropertyResolvingWrapper used to do?
right, `PropertyResolvingWrapper` was joining arguments which are within `"`
-------------
PR: https://git.openjdk.java.net/jdk/pull/370
More information about the serviceability-dev
mailing list