RFR: 8252003: remove usage of PropertyResolvingWrapper in vmTestbase/nsk/jvmti
Igor Ignatyev
iignatyev at openjdk.java.net
Wed Sep 30 18:23:21 UTC 2020
On Wed, 30 Sep 2020 18:16:42 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:
>> not in the tests which use `nsk/share/jvmti/ArgumentHandler`, otherwise, we would see these tests failing as wouldn't
>> parse them correctly. quick grepping showed that that
>> * `~` is used in `vm/mlvm/*/jvmti` tests, but these tests don't use `nsk/share/jvmti/ArgumentHandler`, they use
>> `nsk/share/ArgumentParser/IgnoreUnknownArgumentParser` which doesn't parse agent options string at all
>> * `,` has been used in `nsk/jvmti/scenarios/contention/TC05/tc05t001/` before this patch, and the test wasn't getting
>> options right, it was setting `verbose,waittime` equal to `5`, instead of `verbose` to an empty string and `waittime`
>> to `5`.
>
> Ok.
after writing all of this, I think it makes sense to separate the fix in `ArgumentHandler` for the sake of clarity and
easy of backporting. @plummercj, what do you think?
-------------
PR: https://git.openjdk.java.net/jdk/pull/370
More information about the serviceability-dev
mailing list