RFR: 8252003: remove usage of PropertyResolvingWrapper in vmTestbase/nsk/jvmti [v2]

Igor Ignatyev iignatyev at openjdk.java.net
Wed Sep 30 20:56:40 UTC 2020


> Hi all,
> 
> could you please review the patch which removes `PropertyResolvingWrapper` from `vmTestbase/nsk/jvmti` tests? as
> `jtreg` doesn't support spaces in the arguments and doesn't handle `"` in any special ways, the patch also:
>  - `s/"-javaOpts=/-javaOpts="/`
>  - makes `nsk.jvmti.scenarios.general_functions.GF08` to use 2nd arg as `verboseType` and 3rd and the rest args
>    concatenated as `phrase` and updates the tests accordingly
>  - removes spaces and surrounding `"` from `nsk.jvmti.test.property*`
>  - removes `"` surrounding `-agentlib:`, replaces spaces in `-agentlib` with `,` and updates `ArgumentHandler` to treat
>    `,` (as well as ` ` and `~`) as options delimiters, so it's consistent w/ `jvmti_tools.cpp`
> 
> testing: ✅  `vmTestbase/nsk/jvmti` on {linux,windows,macos}-x64

Igor Ignatyev has updated the pull request incrementally with one additional commit since the last revision:

  Revert "update ArgumentHandler to use the same delimeters as in jvmti_tools.cpp"

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/370/files
  - new: https://git.openjdk.java.net/jdk/pull/370/files/6190e55b..3489e24d

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=370&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=370&range=00-01

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/370.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/370/head:pull/370

PR: https://git.openjdk.java.net/jdk/pull/370


More information about the serviceability-dev mailing list