RFR: 8230664: Fix TestInstanceKlassSize for PowerPC [v2]

Ziviani github.com+670087+jrziviani at openjdk.java.net
Wed Sep 30 22:15:04 UTC 2020


On Tue, 29 Sep 2020 20:56:24 GMT, Ziviani <github.com+670087+jrziviani at openjdk.org> wrote:

>> Can you please update the JBS issue to accurately describe what the underlying cause is. It incorreclty states that it
>> is 8-byte vs 16-byte aligment.
>> I'd prefer that you added someting like VM.hasAOT(). This will fix the problem for other CPU ports that may be in a
>> similar situation and also ensure correctness when configure a build with `--disable-aot`.
>
> @plummercj
> Thank you for your review!
> 
>> Can you please update the JBS issue to accurately describe what the underlying cause is. It incorreclty states that it
>> is 8-byte vs 16-byte aligment.
> 
> Unfortunately, I don't have write access to the bug system. I'll check if the original reporter would mind adding it
> for me.
>> I'd prefer that you added someting like VM.hasAOT(). This will fix the problem for other CPU ports that may be in a
>> similar situation and also ensure correctness when configure a build with --disable-aot.
> 
> Sure, I'll work on it. I'll update this PR as soon as I finish the tests.
> 
> Thank you!

@plummercj Hello! I implemented `hasAOT()` by using an existing variable in methodCounters that exists only if AOT is
enabled.

**ppc64le**
==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR
   jtreg:test/hotspot/jtreg/serviceability/sa/TestInstanceKlassSize.java
                                                         1     1     0     0
==============================
TEST SUCCESS

==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR
   jtreg:test/hotspot/jtreg/serviceability/sa/TestInstanceKlassSizeForInterface.java
                                                         1     1     0     0
==============================
TEST SUCCESS
**x86-64**
==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR
   jtreg:test/hotspot/jtreg/serviceability/sa/TestInstanceKlassSize.java
                                                         1     1     0     0
==============================
TEST SUCCESS

==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR
   jtreg:test/hotspot/jtreg/serviceability/sa/TestInstanceKlassSizeForInterface.java
                                                         1     1     0     0
==============================
TEST SUCCESS```

-------------

PR: https://git.openjdk.java.net/jdk/pull/358


More information about the serviceability-dev mailing list