RFR: 8257831: Suspend with handshakes [v3]

[David Holmes]

On 1/04/2021 1:29 pm, Patricio Chilano Mateo wrote:
> On Wed, 31 Mar 2021 06:32:40 GMT, David Holmes <dholmes at openjdk.org> wrote:
> 
>>> Robbin Ehn has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
>>>
>>>   - Merge branch 'master' into SuspendInHandshake
>>>   - Merge branch 'master' into SuspendInHandshake
>>>   - 8257831: Suspend with handshake (review baseline)
>>
>> src/hotspot/share/runtime/thread.cpp line 667:
>>
>>> 665:
>>> 666:       // We wait for the thread to transition to a more usable state.
>>> 667:       for (int i = 1; i <= SuspendRetryCount; i++) {
>>
>> You will need to obsolete SuspendRetryCount and SuspendRetryDelay. This will need a CSR request indicating why there is no deprecation step.
> 
> I think we will need to do the same for flags AssertOnSuspendWaitFailure and TraceSuspendWaitFailures.

Well spotted - both of those flags are unused already - their use was 
deleted with JDK-8223312, but we overlooked dropping the flags themselves.

Cheers,
David



> -------------
> 
> PR: https://git.openjdk.java.net/jdk/pull/3191
>