RFR: 8264411: serviceability/jvmti/HeapMonitor tests intermittently fail due to large TLAB size [v3]

Hui Shi hshi at openjdk.java.net
Sat Apr 3 04:09:53 UTC 2021


> …ue to large TLAB size
> 
> serviceability/jvmti/HeapMonitor tests intermittently fail when using PS/Serial GC, original test has implicit assumptions on TLAB size and depends on allocate fix amount of objects to consume TLAB and trigger object sampling. These tests will fail if TLAB is above 20M (this can easily happen when using PS/Serial GC and heap is large), when allocation can not consume current TLAB and _byte_until_sample.
> 
> Fix in tests is adding an explicit GC to consume current TLAB.
> Running on 256G memory machine, make run-test CONF=release TEST="test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/" 'JTREG=JOBS=12;VM_OPTIONS=-XX:ActiveProcessorCount=1'
> 
> before fix: 6 or 7 tests in 20 tests intermittently fail
> after fix: no failure in 100 runs release/fastdebug
> 
> This might also fix https://bugs.openjdk.java.net/browse/JDK-8225313

Hui Shi has updated the pull request incrementally with one additional commit since the last revision:

  clarify comments

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/3265/files
  - new: https://git.openjdk.java.net/jdk/pull/3265/files/3dd108d5..158b54c1

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3265&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3265&range=01-02

  Stats: 19 lines in 2 files changed: 3 ins; 8 del; 8 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3265.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3265/head:pull/3265

PR: https://git.openjdk.java.net/jdk/pull/3265


More information about the serviceability-dev mailing list