RFR: 8263636: Add --disableregistry option to jhsdb debugd [v2]

Yasumasa Suenaga ysuenaga at openjdk.java.net
Mon Apr 5 00:31:14 UTC 2021


On Fri, 2 Apr 2021 20:34:37 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Yasumasa Suenaga has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix comments
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/SALauncher.java line 89:
> 
>> 87:         if (canConnectToRemote) {
>> 88:             System.out.println("          or  jhsdb " + mode + " --connect debugserver");
>> 89:             System.out.println("          or  jhsdb " + mode + " --connect id at debugserver:1234");
> 
> Your change here makes it look like if you specify `id@` then you also need to specify the port. I'd suggest also including the original line that just has `id at debugserver`.

I reverted the original line in new commit.

We can also specify port number without `id@` (e.g. `--connect debugserver:1234`). Is it ok not to describe on help message? IMHO it is not good to describe all patterns because it might be verbosely.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3233


More information about the serviceability-dev mailing list