RFR: 8263636: Add --disableregistry option to jhsdb debugd [v2]

Chris Plummer cjplummer at openjdk.java.net
Mon Apr 5 21:03:19 UTC 2021


On Mon, 5 Apr 2021 00:25:38 GMT, Yasumasa Suenaga <ysuenaga at openjdk.org> wrote:

>> `jhsdb debugd` will start RMI registry by default, but we want to prevent it due to port confliction in some cases. We can control it with `sun.jvm.hotspot.rmi.startRegistry` system property. However we have no way to set it excepting system property. jhsdb should provide the way to set it as a command line option.
>> 
>> This PR introduces `--disableregistry` to `jhsdb debugd`. Please review [CSR](https://bugs.openjdk.java.net/browse/JDK-8264021) too.
>
> Yasumasa Suenaga has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix comments

test/hotspot/jtreg/serviceability/sa/sadebugd/DebugdRmidTest.java line 51:

> 49:         JDKToolLauncher rmidLauncher = JDKToolLauncher.createUsingTestJDK("rmid");
> 50:         rmidLauncher.addToolArg("-J-Dsun.rmi.activation.execPolicy=none");
> 51:         rmidLauncher.addToolArg("-J--add-modules=jdk.hotspot.agent");

Is this really needed? Although SA will be using rmid, I don't understand why rmid needs to know about SA.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3233


More information about the serviceability-dev mailing list